Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSHDBGeometryBuilder - Multipolygon with two outer rings and two inner rings touching in two nodes #123

Closed
2 tasks done
kathap opened this issue Mar 11, 2019 · 1 comment
Closed
2 tasks done

OSHDBGeometryBuilder - Multipolygon with two outer rings and two inner rings touching in two nodes #123

kathap opened this issue Mar 11, 2019 · 1 comment
Labels
bug Something isn't working as expected moved from gitlab This issue is still relevant but the old repository is closed down. So please work on it here. unit tests Issues with tests
Projects
Improve OSHDBGeometryBuilder

Comments

@kathap
Copy link
Contributor

kathap commented Mar 11, 2019 •
edited by tyrasd
Loading

image1

code for these tests
@kathap kathap added bug Something isn't working as expected unit tests Issues with tests labels Mar 11, 2019
@SlowMo24 SlowMo24 added moved from gitlab This issue is still relevant but the old repository is closed down. So please work on it here. and removed moved from gitlab This issue is still relevant but the old repository is closed down. So please work on it here. labels Mar 13, 2019
@tyrasd
Copy link
Member

tyrasd commented Apr 11, 2019

I believe 778 is not really a valid test case.

According to https://wiki.openstreetmap.org/wiki/Relation:multipolygon: “[inner ways make] up the optional inner ring(s) delimiting the excluded holes that must be fully inside the area delimited by outer ring(s).”

For overlapping inner rings (such as it is the case here), it is not defined if the geometry building algorithm should use the even-odd rule, the non-zero-winding rule, a subtractive algorithm or something else.

@tyrasd tyrasd closed this as completed Apr 11, 2019
Improve OSHDBGeometryBuilder automation moved this from To do to Done Apr 11, 2019
@tyrasd tyrasd mentioned this issue Jun 17, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected moved from gitlab This issue is still relevant but the old repository is closed down. So please work on it here. unit tests Issues with tests
Projects
No open projects
Improve OSHDBGeometryBuilder
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tyrasd @SlowMo24 @kathap