check timestamps when aggregating #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if outside of query's timestamps range -> throw exception
…ByTimestamp i.e. when the indexer returns timestamp outside query time range
rtroilo
reviewed
Apr 4, 2020
oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/MapAggregator.java
Outdated
Show resolved
Hide resolved
oshdb-api/src/main/java/org/heigit/bigspatialdata/oshdb/api/mapreducer/MapReducer.java
Outdated
Show resolved
Hide resolved
rtroilo
approved these changes
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
aggregateByTimestamps(callback)function returns timestamps outside of the query's time range, an explicit exception will now be thrown.Before this case was not checked and did in some cases to hard to debug
NullPointerExceptions in various places (e.g. inOSHDBCombinedIndex.compareTo, or potentially even inconsistent results.