Removing UNKNOWN from OSMType, throw Exception instead! #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrasd
reviewed
Oct 14, 2019
oshdb-util/src/test/java/org/heigit/bigspatialdata/oshdb/util/xmlreader/OSMXmlReader.java
Outdated
Show resolved
Hide resolved
tyrasd
reviewed
Oct 14, 2019
...etl/src/main/java/org/heigit/bigspatialdata/oshdb/tool/importer/extract/TypeStartFinder.java
Outdated
Show resolved
Hide resolved
|
ping? I agree that this would be a good change for code clarity. For example, it would have allowed to write https://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/libs/ohsome-filter/blob/51227047/src/main/java/org/heigit/ohsome/filter/TypeFilter.java#L41-42 in a more simplified way. 😉 But there are still two minor comments that need to be clarified before we can go on with merging this. |
|
I'm not sure which minor comments you refer, but I think I solved them already
Now there is an IllegalArgumentException instead of a NullPointerException And thank you for fixing the Typo ;-) |
tyrasd
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Type of change
Please delete if not relevant:
Description