Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make monthly time intervals more intuitive #201

Merged
merged 2 commits into from
Nov 11, 2019
Merged

make monthly time intervals more intuitive #201

merged 2 commits into from
Nov 11, 2019

Conversation

mcauer
Copy link
Member

@mcauer mcauer commented Nov 11, 2019 •
edited

Changes proposed in this pull request:

Type of change

Please delete if not relevant:

  • Breaking change

Description

Fixes https://gitlab.gistools.geog.uni-heidelberg.de/giscience/big-data/ohsome/ohsome-api/issues/63: unexpected/unintuitive result when using a "monthly" time interval.

Checklist

@mcauer mcauer added the bug Something isn't working as expected label Nov 11, 2019
@mcauer mcauer requested a review from tyrasd November 11, 2019 13:56
@mcauer mcauer self-assigned this Nov 11, 2019
@tyrasd tyrasd removed the bug Something isn't working as expected label Nov 11, 2019
tyrasd
tyrasd approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great 👍

tyrasd
tyrasd requested changes Nov 11, 2019
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, could you please add a line to the changelog (and update the documentation if necessary) for this? thanks!

@tyrasd tyrasd changed the title fix timestamp processing for end of the month differences. make monthly time intervals more intuitive Nov 11, 2019
@tyrasd tyrasd merged commit 0c0d121 into master Nov 11, 2019
@tyrasd tyrasd deleted the fix-timestamp_processing branch November 11, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

Assignees

@mcauer mcauer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcauer @tyrasd