Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code style in map-reducer package #216

Merged
merged 5 commits into from
Apr 4, 2020
Merged

Improve code style in map-reducer package #216

merged 5 commits into from
Apr 4, 2020

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Feb 26, 2020 •
edited

Brings checkstyle warnings down to 0 馃帀 for the oshdb api module by:

  • "easy" fixes (too long lines, unused imports, wrong indentions, javadoc formatting).
  • getting rid of "helper" classes ob map-reducer backends by inlining their static methods (which were each only called once).

//edit: now also 0 馃帀 PMD warnings.

Checklist

@tyrasd
code style fixes
748c553 
fixes various issues found by checkstyle, e.g. too long lines, unused imports, wrong indention
@tyrasd
get rid of unnecessary sub-class, inline static methods
726ab4e
@tyrasd
get rid of unnecessary sub-class, inline static methods
0c4caae
@tyrasd
drop more unused imports
6cc7b14
@tyrasd
make it more explicit that the catch path is the expected one
6b538f2 
this avoids an (except for a comment otherwise) empty catch block, which could result in warnings from static code analysis tools
@tyrasd tyrasd added the waiting for review This pull request needs a code review label Feb 27, 2020
rtroilo
rtroilo approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice clean up 馃憤

@tyrasd tyrasd merged commit 33b7edf into master Apr 4, 2020
@tyrasd tyrasd deleted the improve-code-style-mapreducers branch April 4, 2020 09:26
@tyrasd tyrasd removed the waiting for review This pull request needs a code review label Apr 4, 2020
@tyrasd tyrasd added the code quality Related to our standards for 'good' code label Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtroilo rtroilo rtroilo approved these changes

Assignees
No one assigned
Labels
code quality Related to our standards for 'good' code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tyrasd @rtroilo