Fix exception while requesting specific broken multipolygons #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes building of multipolygon geometries more robust: Some (rare?) invalid geometries cannot simply be cleaned with the buffer(0) trick. This then results in ClassCastExceptions. This fix just removes these invalid geometry parts of the affected multipolygons.
tyrasd
commented
May 11, 2020
...b-util/src/main/java/org/heigit/bigspatialdata/oshdb/util/geometry/OSHDBGeometryBuilder.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes building of broken multipolygon objects' geometries more robust by asserting that buffered invalid outers are actual polygons.
Some (rare?) invalid OSM geometries cannot simply be cleaned with the
buffer(0)trick. This then results in ClassCastExceptions in requests like https://api.ohsome.org/v0.9/elements/area?bboxes=140.1010943%2C35.2697236%2C140.1800585%2C35.3308109&format=json&keys=natural&showMetadata=false&time=2018-01-01%2F2020-01-01%2FP1M&types=relation&values=wood.This fix just removes these invalid geometry parts of the affected multipolygons.
Changes proposed in this pull request:
Type of change
Please delete if not relevant:
Checklist