Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change groupId to org.heigit.ohsome, use ohsome-parent #234

Merged
merged 9 commits into from
Jun 25, 2020
Merged

change groupId to org.heigit.ohsome, use ohsome-parent #234

merged 9 commits into from
Jun 25, 2020

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented May 7, 2020

No description provided.

@tyrasd tyrasd added this to the release 0.6.0 milestone May 7, 2020
@tyrasd tyrasd requested review from joker234 and rtroilo May 7, 2020 15:11
rtroilo
rtroilo reviewed May 7, 2020
View reviewed changes
pom.xml Show resolved Hide resolved
joker234
joker234 previously requested changes May 7, 2020
View reviewed changes
Copy link
Member

@joker234 joker234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open TODOs:

  • Move sources src/main/java/org/heigit/bigspatialdata → src/main/java/org/heigit/ohsome
  • Move tests src/test/java/org/heigit/bigspatialdata → src/test/java/org/heigit/ohsome
  • Rename imports
  • Better use grep and find after these changes again, if I missed anything.

pom.xml Show resolved Hide resolved
@joker234 joker234 mentioned this pull request May 15, 2020
Closed
@joker234
Copy link
Member

Open TODOs:

* Move sources `src/main/java/org/heigit/bigspatialdata` → `src/main/java/org/heigit/ohsome`

* Move tests `src/test/java/org/heigit/bigspatialdata` → `src/test/java/org/heigit/ohsome`

* Rename imports

* Better use `grep` and `find` after these changes again, if I missed anything.

moved to #241

joker234
joker234 requested changes May 15, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@tyrasd @joker234
update new parent version in changelog
a597427 
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
@tyrasd tyrasd merged commit 80787a7 into master Jun 25, 2020
@tyrasd tyrasd deleted the ohsome-parent branch June 25, 2020 14:06
@tyrasd tyrasd mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker234 joker234 joker234 approved these changes

@rtroilo rtroilo rtroilo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyrasd @joker234 @rtroilo