Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ohsome parent to 2.4, remove maven-shade-plugin #257

Merged
merged 1 commit into from
Jul 31, 2020
Merged

update ohsome parent to 2.4, remove maven-shade-plugin #257

merged 1 commit into from
Jul 31, 2020

Conversation

joker234
Copy link
Member

@joker234 joker234 commented Jul 31, 2020 •
edited by tyrasd

Changes proposed in this pull request:

Type of change

  • Dependency update

Description

  • update ohsome parent to 2.4
  • remove maven-shade-plugin from oshpbf and etl
  • remove findbugs (reason: is unmaintained)

@joker234 joker234 requested review from tyrasd and rtroilo July 31, 2020 09:32
@joker234 joker234 added dependencies referes to one of our dependencies Java 9+ labels Jul 31, 2020
@joker234 joker234 added this to the release 0.6.0 milestone Jul 31, 2020
@joker234 joker234 force-pushed the ohsome-parent-2.4 branch 2 times, most recently from 589cb1d to 1eebd53 Compare July 31, 2020 16:50
tyrasd
tyrasd approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@tyrasd tyrasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@tyrasd tyrasd merged commit 0435bad into master Jul 31, 2020
@tyrasd tyrasd deleted the ohsome-parent-2.4 branch July 31, 2020 17:38
@tyrasd tyrasd mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

@rtroilo rtroilo Awaiting requested review from rtroilo

Assignees
No one assigned
Labels
dependencies referes to one of our dependencies Java 9+
Projects
None yet
Milestone
release 0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joker234 @tyrasd