catch all remote oshdb timeouts #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they might be nested in various amounts of `IgniteException`s (depending on where in the code they are thrown precisely). this implementation recursively unwinds these nested exceptions, so that the original `OSHDBTimeout` exception is actually thrown.
rtroilo
reviewed
Aug 17, 2020
...ava/org/heigit/bigspatialdata/oshdb/api/mapreducer/backend/MapReducerIgniteAffinityCall.java
Outdated
Show resolved
Hide resolved
now, if the cause is found to be _not_ an oshdb-timeout exception, then the original wrapped (ignite) exception is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a timeout happens remotely (in the ignite cluster), the resulting exception which is thrown in the client might be nested in various levels of
IgniteExceptions (depending on where in the code they are thrown precisely). This implementation recursively unwinds these nested exceptions, so that the originalOSHDBTimeoutexception is actually thrown in all cases.Changes proposed in this pull request:
Type of change
Please delete if not relevant:
Corresponding issue
Fixes GIScience/ohsome-api#10
Checklist
I have adjusted the examples and benchmark if necessary