Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area/length filters should be based on unclipped geometries #433

Closed
tyrasd opened this issue Nov 10, 2021 · 0 comments · Fixed by #434
Closed

area/length filters should be based on unclipped geometries #433

tyrasd opened this issue Nov 10, 2021 · 0 comments · Fixed by #434
Labels
bug Something isn't working as expected

Comments

@tyrasd
Copy link
Member

tyrasd commented Nov 10, 2021

The goal of these filters is to select OSM features with the specified properties (e.g. buildings having a footprint larger than a given size). Currently, area: and length: filters are performed on geometries which are clipped to the query's area of interest, which partly negates the functionality of these filters. Instead, the filters should take the full, unclipped, geometry of OSM features into account.

I'm marking this as a bug because the current behaviour clearly doesn't match the documentation:

matches all features with [an area / a length]

PS: This could in some edge cases also affect the geometry-type filter (geometry:), where because of clipping a geometry could potentially degenerate to a different type (for example, a polygon could collapse into a line or point when the polygon and the area of interest are only touching along their border or a single vertex).

See also ohsome-api#245.

@tyrasd tyrasd added the bug Something isn't working as expected label Nov 10, 2021
@tyrasd tyrasd added this to To do in oshdb filter via automation Nov 10, 2021
@tyrasd tyrasd changed the title area/length filters should ba based on unclipped geometries area/length filters should be based on unclipped geometries Nov 10, 2021
oshdb filter automation moved this from To do to Done Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
Development

Successfully merging a pull request may close this issue.

1 participant