drop "geotools" dependency #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since geotools (which is a fairly heavy library) was only really used in this one helper class
to use bbox coordinate points directly instead of relying on order of points in bbox polygon: tests require strict mathematical right hand rule order to work
tyrasd
force-pushed
the
drop-geotools
branch
from
9f3f776
to
40903bb
Compare
rtroilo
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only the
Countryclass actually uses geotools functionality (i.e. reading in a shapefile). Since this class is not really essential for the oshdb itself, it should therefore probably be better made into a separate library. Then, the few remaining uses of geotools are easily replaced by corresponding JTS methods (one slightly annoying side node: when generating aPolygongeometry from anEnvelopeobject, JTS uses clockwise coordinate winding order while geotools produces counterclockwise winding (i.e. following the mathematical "right hand rule")), which is a small side effect introduced in this PR.See also #2