Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gkernelci into every gentoo/gentoo pull request #12

Open
juippis opened this issue Feb 6, 2021 · 4 comments
Open

Integrate gkernelci into every gentoo/gentoo pull request #12

juippis opened this issue Feb 6, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@juippis
Copy link
Member

juippis commented Feb 6, 2021

Hey,

it'd be nice to have on-demand build-test from gkernelci to gentoo/gentoo pull requests. Here's the summary I wrote for an idea:

Getting a tinderbox to test our Github pull requests, that the contributions
build. Print or link all build output to Github PR. This'd work on-demand,
either by manually launching it from a shell, or even better, with Github
hooks. Using Github hooks I could imagine there to be "build" label which then
launches the process on a tinderbox, and update it to "build finished" when
done.

(Although I'd like a shell/vnc access for runtime testing)

Full text with a conrecte implementation idea can be found from:
https://dev.gentoo.org/~juippis/tmp/automated_pull_request_buildbot.txt

For me, it'd be important this worked on-demand so that people can't troll us with 100 chromium PRs wasting CPU cycles automatically. And ideally we'd launch the build test after checking that the contributed ebuild, etc are fine, and don't download anything from any fishy URLs.

@aliceinwire
Copy link
Member

For me, it'd be important this worked on-demand so that people can't troll us with 100 chromium PRs wasting CPU cycles automatically. And ideally we'd launch the build test after checking that the contributed ebuild, etc are fine, and don't download anything from any fishy URLs.

I like this.
what kind of security do you think are needed for the "on-demand" part.
I could check a comment on the pr for example "build test" for starting manual pr test and maybe we could try to check if the person who wrote the comment is part of the github/gentoo organization.

@juippis
Copy link
Member Author

juippis commented Feb 7, 2021

We could manually add a tag, "build please" or something ("initiate build"), and then depending on the result the hook would update it to "build passed" or "build failed". That'd allow us to browse PRs based on tags, too, on Github.

Only people part of github/gentoo organization are capable of adding tags manually, so that shouldn't be a problem.

@aliceinwire aliceinwire added the enhancement New feature or request label Feb 16, 2021
@aliceinwire aliceinwire self-assigned this Feb 16, 2021
@aliceinwire
Copy link
Member

aliceinwire commented Feb 20, 2021

I currently enabled pull request for sys-kernel/ as test
I'm also trying to implement gkernelci label for force gkernelci testing
https://github.com/gentoo/gentoo/labels/gkernelci
I could check that I can get the label added event in GKernelCI

@aliceinwire
Copy link
Member

skipping tags as been introduced by this buildbot pull request
https://github.com/buildbot/buildbot/pull/3443/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In Progress
Development

No branches or pull requests

2 participants