Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added different page units, python 3, and changed gitignore, portuguese translation #1

Closed
wants to merge 5 commits into from

Conversation

riuri
Copy link

@riuri riuri commented Aug 31, 2017

Page units

  • I added a unit chooser with in, mm, and cm on the page size dialog
  • The corresponding unit is shown in the status bar

Python 3

  • I installed and executed the code in python 3 and manually checked and corrected the differences
  • The changes were mostly except statements and relative imports
  • My setup is currently using python 3.6.2, but I tested using python 2.7.13 and it installed correctly

.gitignore

  • Files generated by autotools were included on the .gitignore file, so now git doesn't complain about not adding those files

Translation

  • Since the changes in the page size dialog and status bar introduce difference translatable strings, the translation files were updated
  • I also translated those strings to Brazilian Portuguese

If github is not the right place to contribute to gnome, please tell me the directions for doing so

@gnomesysadmins
Copy link

Thank you for contributing to ocrfeeder!

ocrfeeder uses Bugzilla for code review.

If you have never contributed to GNOME before make sure you have read the
getting started documentation:
http://www.gnome.org/get-involved

Otherwise please visit
https://wiki.gnome.org/Newcomers
and follow the instructions there to upload your change to Bugzilla.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants