Python 3 support and added Markdown Document generator #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt or where not ocr-ed in the first place. On each export, the ocr will be done again. TODO only do OCR when box has changed.
|
Thank you for contributing to ocrfeeder! ocrfeeder uses GitLab for code review. As such we have forwarded https://gitlab.gnome.org/GNOME/ocrfeeder/issues/12 GNOME's GitLab instance also supports GitHub as one of the possible https://gitlab.gnome.org/users/sign_in If you are interested in sticking around within the GNOME community we https://www.gnome.org/get-involved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a 2to3 on the code in src and fixed bugs manually. I have not exhaustively checked for bugs, but opening a project, pdf, image and exporting it seems to work. The lack of tests make it hard to check whether I broke things or not.
In the utils/graphics.py I changed the PixBuffToImage method which was slow in Python3.
Could you create a branch to merge this request into if you want to accept it? I can then create a new pull request.
My earlier commits represent a fix I made to the exporter code that did not update the data_boxes OCR'd text when exporting. Now the exporter OCR's every box on every page again.
I also added a crude Markdown document generator that includes the images in a seperate directory, akin to the HTML document generator.