Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add a test for pull+deploy of specific "bare" commit #145

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

This is the "pull an older version" that's now supported since
36d65b3

However...this test does not fail when I revert the commits that were supposed to make it work. I'm still debugging that.

This is the "pull an older version" that's now supported since
36d65b3
@cgwalters
Copy link
Member Author

And now that I had a chance to test on top of #146 - this test correctly fails with the f4d832475edcb2bf6fdae2eaa8f8cb1b6a02abf0 commit reverted locally.

@cgwalters
Copy link
Member Author

To clarify, what was confusing is that the "no prune" behavior also occurred when transitioning from 0 > 1 deployments, as well as 1 -> 0. In the normal case of a running system you have at least 1, but my test only had 0.

@cgwalters
Copy link
Member Author

@mbarnes ^

@mbarnes
Copy link
Contributor

mbarnes commented Oct 7, 2015

Looks good, and I gotta remember to use rev-parse in future tests. That's handy.

I think it wouldn't hurt to link to this PR in the test script for posterity. Sometimes it's not entirely clear what a test is testing for.

Otherwise, 👍

cgwalters added a commit that referenced this pull request Oct 7, 2015
This is the "pull an older version" that's now supported since
36d65b3

#145
@cgwalters
Copy link
Member Author

Not having a link to the PR conversation is a major gap in this workflow now. =(

Maybe we can just do it manually - submit your PR, then use git rebase to add the PR link to the bottom of each commit? Could be automated.

@cgwalters
Copy link
Member Author

Thanks though, pushed as b6e2eaf

@cgwalters cgwalters closed this Oct 7, 2015
rfairley pushed a commit to rfairley/ostree that referenced this pull request Apr 17, 2019
build: Add support for automatic overrides in `overrides/rpm`
rfairley pushed a commit to rfairley/ostree that referenced this pull request Apr 17, 2019
Adds note regarding changes in ostreedev#145 - personally found this helpful
when testing Ignition changes in FCOS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants