Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNS3 2.1.1 release still contains 2.1.0 GUI #2378

Closed
david-ramsden opened this issue Jan 3, 2018 · 8 comments
Closed

GNS3 2.1.1 release still contains 2.1.0 GUI #2378

david-ramsden opened this issue Jan 3, 2018 · 8 comments
Assignees
Labels
Milestone

Comments

@david-ramsden
Copy link

david-ramsden commented Jan 3, 2018

Hello.

I upgraded my VM to v2.1.1 which seems to have completed without any issues.

But the 2.1.1 all in one release (https://github.com/GNS3/gns3-gui/releases/download/v2.1.1/GNS3-2.1.1-all-in-one.exe) still seems to contain the 2.1.0 GUI.

I tried uninstalling and reinstalling but same issue. I also noted that when I uninstalled GNS3 it was very slow to uninstall.

Also seen this in the GNS3 community forum: https://www.gns3.com/qa/ver-2-1-1-upgrade-from-2-1-0-ver

image

image

image

image

image

@david-ramsden
Copy link
Author

Or maybe it does contain the 2.1.1 GUI but someone forgot to bump the version number somewhere...?

@ziajka ziajka added the Bug label Jan 3, 2018
@ziajka ziajka added this to the 2.1.2 milestone Jan 3, 2018
@david-ramsden
Copy link
Author

david-ramsden commented Jan 3, 2018

Yep I think someone forgot to change gns3/version.py before making the release. So the build is 2.1.1 but it identifies itself to the server as 2.1.0.

@ziajka
Copy link
Contributor

ziajka commented Jan 3, 2018

https://github.com/GNS3/gns3-gui/blob/v2.1.1/gns3/version.py

Version was correct, it must be something different.

@david-ramsden
Copy link
Author

david-ramsden commented Jan 3, 2018

Hey @ziajka, I used uncompyle6 to decompile the version.pyc bytecode from my 2.1.1 install which shows:

$ uncompyle6 version.pyc
# uncompyle6 version 2.14.1
# Python bytecode 3.6 (3379)
# Decompiled from: Python 2.7.6 (default, Oct 26 2016, 20:30:19)
# [GCC 4.8.4]
# Embedded file name: ./gns3-gui\gns3\version.py
# Compiled at: 2017-11-09 01:42:11
__version__ = '2.1.0'
__version_info__ = (2, 1, 0, 0)
if 'dev' in __version__:
    pass
try:
    import os, subprocess
    if os.path.exists(os.path.join(os.path.dirname(os.path.abspath(__file__)), '..', '.git')):
        r = subprocess.check_output(['git', 'rev-parse', '--short', 'HEAD']).decode().strip('\n')
        __version__ += '-' + r
except Exception as e:
    print(e)
# okay decompiling version.pyc

As you see __version__ shows 2.1.0

@ziajka
Copy link
Contributor

ziajka commented Jan 3, 2018

Hi @syndgr, thanks. Indeed something is wrong, we had some issues with AppVeyor. during this release. It seems to be wrong packed. Also "Compiled at: 2017-11-09 01:42:11" says it's previous version.

@david-ramsden
Copy link
Author

I just noticed a comment on the GNS3 blog for 2.1.1 release announcement with someone else reporting the same issue.

As per their comment I deleted C:\Program Files\GNS3 without uninstalling GNS3 and then ran the 2.1.1 installer again. This fixed the issue. So quite possibly the release is good but there's a bug with the installer where it doesn't overwrite some files?

Per my screenshots my gns3.exe got overwritten but the decompile of version.pyc suggests this did not.

@grossmj
Copy link
Member

grossmj commented Jan 7, 2018

Installing GNS3 2.1.1 without first uninstalling 2.0.3 results in the following error when launching gns3.exe:

C:\Program Files\GNS3>gns3.exe
Traceback (most recent call last):
  File "C:\Python36-x64\lib\site-packages\cx_Freeze\initscripts\__startup__.py", line 14, in run
  File "C:\Python36-x64\lib\site-packages\cx_Freeze\initscripts\Console.py", line 26, in run
  File "gns3-gui/gns3/main.py", line 55, in <module>
  File "./gns3-gui\gns3\main_window.py", line 28, in <module>
  File "./gns3-gui\gns3\local_server.py", line 39, in <module>
  File "./gns3-gui\gns3\utils\http.py", line 19, in <module>
  File "C:\Python36-x64\lib\ssl.py", line 118, in <module>
ImportError: cannot import name 'HAS_TLSv1_3'

@grossmj
Copy link
Member

grossmj commented Jan 8, 2018

Something was wrong happened when all-in-one installer has been packaged. We will release 2.1.2 to fix this issue.

@grossmj grossmj closed this as completed Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants