Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of xterm is breaking the build 🚨 #632

Closed
greenkeeper bot opened this issue Dec 5, 2019 · 1 comment
Closed

An in-range update of xterm is breaking the build 🚨 #632

greenkeeper bot opened this issue Dec 5, 2019 · 1 comment

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Dec 5, 2019

The dependency xterm was updated from 4.2.0 to 4.3.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

xterm is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/travis-ci/push: The Travis CI build is in progress (Details).
  • continuous-integration/appveyor/branch: Waiting for AppVeyor build to complete (Details).
  • ci/circleci: build: Your tests failed on CircleCI (Details).

Release Notes for 4.3.0

The WebGL renderer addon got quite a bit of work done on it this release and is quickly approaching parity with the other renderers. It has also been integrated into VS Code as an experimental option.

From our benchmarks the WebGL renderer renders frames up to 900% faster than the canvas renderer and even more in extreme cases where there are hardware issues with the canvas renderer.

image

Here's a comparison of example frames rendered using the canvas and webgl renderers (Windows 10, Intel Xeon E5-1620 @ 3.5GHz, AMD FirePro W2100):

webgl1

Faster rendering also means more frames overall and faster commands. The below is a run of ls -lR on the same machine inside the VS Code codebase:

webgl2

Read more about why it's so good in microsoft/vscode#84440 🔥

🚀 Features

  • The new option minimumContrastRatio has been added that dynamically changes the foreground color to improve contrast (#2563, #2602) via @Tyriar

    mcr

📦 API

  • The new onBinary event enabled support for some mouse report events that cannot be expressed in JS strings (UTF8) (#2566) via @jerch

🐞 Bug fixes

  • Only re-render rows that have changed (#2536, #2582) via @Tyriar
  • Re-render rows when options have changed (#2550) via @Tyriar
  • Force foreground color to be opaque when using a transparent background (#2560) via @ivanwonder
  • Include the backtick as a default word separator (#2583) via @Tyriar

📝 Documentation and internal improvements

🎉 New real-world use cases


📥 Addons

xterm-addon-search

  • Fix search results missing when searching wrapped lines (#2532) via @glneto

xterm-addon-webgl

🤝 Compatible addon versions

  • xterm-addon-attach@0.4.0
  • xterm-addon-fit@0.3.0
  • xterm-addon-search@0.4.0
  • xterm-addon-ligatures@0.2.1
  • xterm-addon-web-links@0.2.1
  • xterm-addon-webgl@0.4.0

🌐 Website

Commits

The new version differs by 209 commits.

  • bd0d267 Merge pull request #2605 from Tyriar/r43
  • c9babb9 v4.3.0
  • 17cb610 Merge pull request #2602 from Tyriar/fix_dom
  • 543b3d6 Fix minimumContrastRatio on dom/truecolor
  • 8b5c48f Merge pull request #2560 from ivanwonder/reverse-transparency
  • 1ff1809 Support opaque inverse background in webgl, add test
  • ef05a6a Draw transparent background in WebGL renderer
  • bceddfb Cover inverse non-black uncached case in canvas renderer
  • 4cd8b22 Use toRgba helper
  • 1a5c3f9 Properly set non-black transparency backgrounds
  • cbb8dc7 Merge remote-tracking branch 'ups/master' into pr/ivanwonder/2560
  • 3b1479a Merge pull request #2585 from Tyriar/unused
  • afe6cb6 Remove unused imports/functions
  • 2173a53 Merge pull request #2583 from xtermjs/Tyriar-patch-1
  • 25f2e66 Include ` in word separators

There are 209 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Dec 5, 2019

After pinning to 4.2.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant