Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arp table drop the VPCS if there is some rows in arp-table. Same as #355 issue #45

Closed
VNVetrov opened this issue Mar 22, 2023 · 12 comments

Comments

@VNVetrov
Copy link

So if I create a basic project with 2 VPCS connected by wire and then I set ip for at least one VPCS, then I do "arp" - it says "arp table is empty", then I ping other VPCS, then I do "arp" again, but it crashes

Console log below:

Trying ::1...
Connected to localhost.
Escape character is '^]'.

Welcome to Virtual PC Simulator, version 0.8.2
Dedicated to Daling.
Build time: Aug 23 2021 03:18:07
Copyright (c) 2007-2015, Paul Meng (mirnshi@gmail.com)
All rights reserved.

VPCS is free software, distributed under the terms of the "BSD" licence.
Source code and license can be found at vpcs.sf.net.
For more information, please visit wiki.freecode.com.cn.

Press '?' to get help.

Executing the startup file

PC1> ip 192.168.32.1
Checking for duplicate address...
PC1 : 192.168.32.1 255.255.255.0

PC1> show arp

arp table is empty

PC1> ping 192.168.32.2

84 bytes from 192.168.32.2 icmp_seq=1 ttl=64 time=0.357 ms
84 bytes from 192.168.32.2 icmp_seq=2 ttl=64 time=0.568 ms
84 bytes from 192.168.32.2 icmp_seq=3 ttl=64 time=0.703 ms
84 bytes from 192.168.32.2 icmp_seq=4 ttl=64 time=0.661 ms
84 bytes from 192.168.32.2 icmp_seq=5 ttl=64 time=0.639 ms

PC1> arpConnection closed by foreign host.

Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

@VNVetrov VNVetrov changed the title Arp table drop the VPCS if there is some rows in arp-table Arp table drop the VPCS if there is some rows in arp-table. Same as #355 issue Mar 22, 2023
@grossmj grossmj transferred this issue from GNS3/gns3-server Mar 23, 2023
@grossmj
Copy link
Member

grossmj commented May 14, 2023

@Raizo62 please can you confirm the bug and maybe propose a fix? That would be very helpful. Thanks a lot 👍

@Raizo62
Copy link
Contributor

Raizo62 commented May 14, 2023

Hi @VNVetrov

I can't reproduce your bug (with the last code of VPCS, on Linux). Do you still have it?

If yes, do you use the last version of VPCS ? can i have more details (schema, IP, OS of host) ?
It is strange that "ping 192.168.32.2" works then no interface has this address in your explanations

@VNVetrov
Copy link
Author

VNVetrov commented May 19, 2023

Hi @VNVetrov

I can't reproduce your bug (with the last code of VPCS, on Linux). Do you still have it?

If yes, do you use the last version of VPCS ? can i have more details (schema, IP, OS of host) ? It is strange that "ping 192.168.32.2" works then no interface has this address in your explanations

It happens on Macbook Air M1 Model A2337. I used the latests version at the moment (2.2.38) of GNS and VPCS, but i also checked this on previous version, so this problem is quite often.
macOS: 13.2.1 (22D68)

image

In the test I gave to PC1 ip 192.168.32.1 and PC2 ip 192.168.32.2.
After that I enter PC1 console, ping PC2 and then I try to check arp table, PC1 crashing...

@Raizo62
Copy link
Contributor

Raizo62 commented May 22, 2023

I don't have a MacBook to investigate.
I have to look for a virtual machine with this system.

@grossmj
Copy link
Member

grossmj commented Aug 1, 2023

I confirm the issue happens on macOS.

Image

No crash on Linux:

Image

@Raizo62
Copy link
Contributor

Raizo62 commented Aug 1, 2023

Could you test with this branch https://github.com/Raizo62/vpcs/tree/MacOS ?
So far I've only applied cppcheck's advice

@grossmj
Copy link
Member

grossmj commented Aug 2, 2023

Could you test with this branch https://github.com/Raizo62/vpcs/tree/MacOS ?

Same result, vpcs crashes on show arp

@Raizo62
Copy link
Contributor

Raizo62 commented Aug 29, 2023

Hi

Could you test again with this branch https://github.com/Raizo62/vpcs/tree/MacOS ?

@grossmj
Copy link
Member

grossmj commented Sep 7, 2023

Could you test again with this branch https://github.com/Raizo62/vpcs/tree/MacOS ?

I think you fixed the bug. I tested and no crash this time. Please can you create a PR? Thanks 👍

@grossmj
Copy link
Member

grossmj commented Sep 9, 2023

Thanks to @Raizo62 the bug has been fixed. vpcs v0.8.3 has been released: https://github.com/GNS3/vpcs/releases/tag/v0.8.3 (the macOS executable can be download from there) and it will be included in the next GNS3 version.

@grossmj grossmj closed this as completed Sep 9, 2023
@VNVetrov
Copy link
Author

Thanks to @Raizo62 the bug has been fixed. vpcs v0.8.3 has been released: https://github.com/GNS3/vpcs/releases/tag/v0.8.3 (the macOS executable can be download from there) and it will be included in the next GNS3 version.

Could you please tell me how to install it to a GNS3?

@grossmj
Copy link
Member

grossmj commented Sep 11, 2023

Could you please tell me how to install it to a GNS3?

Download the binary from https://github.com/GNS3/vpcs/releases/download/v0.8.3/vpcs-osx and replace the one inside the app, the path should be something like: /Applications/GNS3.app/Contents/MacOS/vpcs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants