Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-561: Add correct value range for "reading unit" #18

Closed

Conversation

alexanderpetkov
Copy link
Contributor

@jobara
Copy link
Member

jobara commented Jan 31, 2014

@radmanovi4 how does this relate to #17 is one a continuation of the other and are they in sync?

In GPIIStore.js, related to providing model trnasformations.
@alexanderpetkov
Copy link
Contributor Author

@jobara, no, this pull doesn't relate to #17. Perhaps you ask that question because of the minor change in GPIIStore.js I had commited, which indeed makes the pull a bit confusing. I've removed it now so the pull only relates to GPII-561 (as small as it is :)).

@jobara
Copy link
Member

jobara commented Feb 3, 2014

@radmanovi4 yes that was it. That change seemed to be in both pull requests.

@jobara
Copy link
Member

jobara commented Feb 3, 2014

@radmanovi4 so the change is fine in regards to the enum and control values. However, you should take care to source the strings, for displaying on the interface, from the message bundle. Take a look at how the language adjuster was modified for this.

@alexanderpetkov
Copy link
Contributor Author

@jobara I see what you've described in your last comment has already been done here 30c216f. I guess this pull can be closed now?

@jobara
Copy link
Member

jobara commented Mar 14, 2014

@kaspermarkus this pull request can be closed.

@kaspermarkus
Copy link
Contributor

@jobara closed or merged?

@jobara
Copy link
Member

jobara commented Mar 14, 2014

@kaspermarkus closed, see @radmanovi4 previous comment.

@kaspermarkus
Copy link
Contributor

Cool, thanks Justin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants