Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sRGB dxgi formats support? #114

Open
Zelex opened this issue May 27, 2020 · 4 comments
Open

sRGB dxgi formats support? #114

Zelex opened this issue May 27, 2020 · 4 comments
Assignees
Labels

Comments

@Zelex
Copy link

Zelex commented May 27, 2020

It appears as though BC1_UNORM vs BC1_UNORM_SRGB decode 100% identically.

Pretty sure that should be a bug?

@Zelex
Copy link
Author

Zelex commented May 27, 2020

Also, it seems I cannot attach DDS files to issues =/ Though thats a github issue, not your issue per-se. let me know if you want some test files. I can email some no problem.

@NPCompress
Copy link
Contributor

@Zelex try zip

@Zelex
Copy link
Author

Zelex commented May 27, 2020

kodim01_srgb.zip
yay! :)

@NPCompress NPCompress self-assigned this Jun 10, 2020
@NPCompress NPCompress added the bug label Jun 10, 2020
@expenses
Copy link

expenses commented Dec 4, 2023

I'm going to link #277 because they're really the same issue. This problem is really annoying because it means that you have to know the context that an image is going to be used in before loading it - BC7_UNORM images have to be loaded as BC7_UNORM_SRGB images when used for colour data. It's a pretty simple fix, just use a flag that sets whether a _SRGB format is set or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants