-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect equations in SGPR_notes #1753
Comments
The next-to-the-last equation in the documentation page is correct, as shown here. |
Hi @joacorapela , it's great that you're carefully going through the docs, and thanks for raising what you saw as a mistake! |
Thanks @st-- . The third to the last equation in the GPflow documentation page correctly states Kuu⁻¹ Λ Kuu⁻¹ = L⁻ᵀ and as proved here the GPflow documentation is correct. What do you think? |
There's clearly a bug somewhere. I'm not quite sure where it is. One way that I find helpful is to think of covariance matrices as having "units". So e.g. We can see that the equations for |
In other words, |
Thanks for your comment @st--. I believe there is a typo in the third to the last equation of this GPflow note. The right hand side of this equation should contain |
I think we'd resolved this now ? If anyone disagrees please shout and we can reopen it:) |
Bug / performance issue / build issue
I believe there is an error in the next-to-last equation in the documentation page at https://gpflow.readthedocs.io/en/master/notebooks/theory/SGPR_notes.html, which makes the last prediction equation invalid. I provide details at http://www.gatsby.ucl.ac.uk/~rapela/gpflow/wrongPredictionEq.pdf. Can this be right?
The text was updated successfully, but these errors were encountered: