Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noted cpython 3.8 bug #2031

Merged
merged 1 commit into from Jan 23, 2023
Merged

Noted cpython 3.8 bug #2031

merged 1 commit into from Jan 23, 2023

Conversation

sc336
Copy link
Contributor

@sc336 sc336 commented Dec 14, 2022

PR type: doc improvement

Related issue(s)/PRs

Summary

The bug in cpython3.8 linked above is causing our benchmarking to fail. This isn't really fixable by us, so I've added a warning comment to prevent people banging their heads against this issue.

Fully backwards compatible: yes

PR checklist

  • New features: code is well-documented
    • detailed docstrings (API documentation)
    • notebook examples (usage demonstration)
  • The bug case / new feature is covered by unit tests
  • Code has type annotations
  • Build checks
    • I ran the black+isort formatter (make format)
    • I locally tested that the tests pass (make check-all)
  • Release management
    • RELEASE.md updated with entry for this change
    • New contributors: I've added myself to CONTRIBUTORS.md

@sc336 sc336 changed the title Noted bug here Noted cpython 3.8 bug Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 98.01% // Head: 98.01% // No change to project coverage 👍

Coverage data is based on head (2deea64) compared to base (abf4289).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2031   +/-   ##
========================================
  Coverage    98.01%   98.01%           
========================================
  Files           96       96           
  Lines         5401     5401           
========================================
  Hits          5294     5294           
  Misses         107      107           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@uri-granta uri-granta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sc336 sc336 merged commit c3610b9 into develop Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants