Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontends update #110

Merged
merged 26 commits into from
Mar 11, 2024
Merged

Frontends update #110

merged 26 commits into from
Mar 11, 2024

Conversation

vabor112
Copy link
Member

No description provided.

@vabor112 vabor112 marked this pull request as ready for review February 12, 2024 21:14
… rather than on the type of the input. This helps to accomodate JAX tracer lengthscales better.
Copy link
Collaborator

@stoprightthere stoprightthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job overall, have some minor questions and have yet to run the notebooks

geometric_kernels/frontends/pytorch/gpytorch.py Outdated Show resolved Hide resolved
geometric_kernels/frontends/pytorch/gpytorch.py Outdated Show resolved Hide resolved
geometric_kernels/frontends/pytorch/gpytorch.py Outdated Show resolved Hide resolved
geometric_kernels/kernels/geometric_kernels.py Outdated Show resolved Hide resolved
geometric_kernels/sampling/samplers.py Outdated Show resolved Hide resolved
…fault (with instructions on how to make it trainable)
Copy link
Collaborator

@stoprightthere stoprightthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor comments and suggestions!

geometric_kernels/frontends/jax/gpjax.py Outdated Show resolved Hide resolved
geometric_kernels/frontends/pytorch/gpytorch.py Outdated Show resolved Hide resolved
geometric_kernels/frontends/tensorflow/gpflow.py Outdated Show resolved Hide resolved
vabor112 and others added 2 commits March 10, 2024 22:07
Co-authored-by: stoprightthere <stoprightthere@users.noreply.github.com>
Signed-off-by: Viacheslav Borovitskiy <vabor112@users.noreply.github.com>
@vabor112 vabor112 merged commit 0412b6e into devel Mar 11, 2024
4 checks passed
@vabor112 vabor112 deleted the slava/frontends_update branch April 23, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants