Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/compare #28

Merged
merged 27 commits into from
Jan 4, 2024
Merged

Feature/compare #28

merged 27 commits into from
Jan 4, 2024

Conversation

rshewitt
Copy link
Contributor

@rshewitt rshewitt commented Jan 3, 2024 •
edited
Loading

Pull Request

Related to #4557

About

Add first-pass comparison function including unit and integration tests

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Bumped version number in pyproject.toml (also checked on PyPi).

@rshewitt rshewitt requested a review from a team January 3, 2024 20:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
harvester
   __init__.py120100% 
   compare.py120100% 
   extract.py4877 85%
   load.py1001010 90%
   transform.py1377 46%
harvester/utils
   __init__.py20100% 
   json.py40100% 
   util.py70100% 
harvester/validate
   __init__.py20100% 
   dcat_us.py2433 88%
TOTAL2242788% 

Tests Skipped Failures Errors Time
28 0 💤 0 ❌ 0 🔥 46.817s ⏱️

@rshewitt rshewitt marked this pull request as draft January 3, 2024 21:28
@rshewitt rshewitt marked this pull request as ready for review January 3, 2024 22:07
btylerburton
btylerburton reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall great progress. a bit more documentation and some unit test cases should be sufficient to merge.

README.md Show resolved Hide resolved
harvester/load.py Show resolved Hide resolved
harvester/load.py Show resolved Hide resolved
@rshewitt rshewitt merged commit 9a278fa into main Jan 4, 2024
5 checks passed
@rshewitt rshewitt deleted the feature/compare branch January 4, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robert-bryson robert-bryson robert-bryson approved these changes

@btylerburton btylerburton Awaiting requested review from btylerburton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rshewitt @robert-bryson @btylerburton