Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update db tables #68

Merged
merged 11 commits into from
May 17, 2024
Merged

Update db tables #68

merged 11 commits into from
May 17, 2024

Conversation

rshewitt
Copy link
Contributor

Pull Request

Related to #4731

About

update database tables to reflect what's in the definition document. remove use of sqllite in testing environment because it doesn't support arrays as a dtype which we need for notification_emails in the harvest source table

PR TASKS

  • The actual code changes.
  • Tests written and passed.
  • Any changes to docs?
  • Bumped version number in pyproject.toml (also checked on PyPi).

@rshewitt rshewitt requested a review from a team May 14, 2024 15:20
app/__init__.py Outdated Show resolved Hide resolved
app/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is good to after you update the app.config["TESTING"] line

@btylerburton
Copy link
Contributor

Compare is telling me maybe we should just merge this one as it's got the superset of changes

separate-database...update-db-tables

btylerburton
btylerburton previously approved these changes May 16, 2024
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@btylerburton
Copy link
Contributor

same as other PR, we should get @Jin-Sun-tts or @FuhuXia to review so we get fresh eyes.

@rshewitt rshewitt dismissed btylerburton’s stale review May 17, 2024 14:55

The merge-base changed after approval.

Copy link
Contributor

@jbrown-xentity jbrown-xentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's contained in #72, but looks good!

@rshewitt rshewitt merged commit c7049e2 into main May 17, 2024
4 checks passed
@rshewitt rshewitt deleted the update-db-tables branch May 17, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants