Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabbing highlights missing in some places #133

Open
DaveSkender opened this issue Jun 10, 2022 · 2 comments · May be fixed by #177
Open

Tabbing highlights missing in some places #133

DaveSkender opened this issue Jun 10, 2022 · 2 comments · May be fixed by #177
Assignees
Labels
2023 Sprint 1 Jan - April 2023 Sprint 2 April - May bug Something isn't working
Projects

Comments

@DaveSkender
Copy link
Contributor

Describe the bug

When tabbing through the homepage, clickable elements are highlighted with a consistent thick blue border for visually impaired persons. The two clickable cards (below) do not highlight when they receive focus.

I suspect this highlight may also be missing on the track "bubble" navigation icons (not currently shown on site / out of season).

To Reproduce

  1. Do a fresh reload of the home page without clicking anywhere
  2. Use the keyboard Tab key to navigate through the controls until you get to these cards
  3. Observe that they do not highlight as expected

Expected behavior

It is probably sufficient to have the same effect as is currently on mouse "hover" when tab focus is achieved, though there may also be an existing USWDS style treatment that includes a small amount of object padding that would be better.

Screenshots or other reference materials

image

@DaveSkender DaveSkender added the bug Something isn't working label Jun 10, 2022
@github-actions github-actions bot added this to Triage in the Backlog Jun 10, 2022
@mvdanilova mvdanilova moved this from Triage to To do in the Backlog Jul 5, 2022
@jaredbain jaredbain moved this from To do to In progress in the Backlog Jul 7, 2022
@jaredbain jaredbain linked a pull request Jul 7, 2022 that will close this issue
@Dahianna Dahianna moved this from In progress to To do in the Backlog Sep 6, 2022
@Dahianna Dahianna moved this from To do to Triage in the Backlog Jan 10, 2023
@Dahianna Dahianna added the 2023 Sprint 1 Jan - April label Jan 10, 2023
@Dahianna Dahianna moved this from Triage to To do in the Backlog Jan 10, 2023
@chriskuang4
Copy link
Contributor

Jared will get to this when we circle back to AMP testing for 2023.

@Dahianna Dahianna moved this from To do to In progress in the Backlog Mar 21, 2023
@Dahianna Dahianna added 2023 Sprint 1 Jan - April 2023 Sprint 2 April - May and removed 2023 Sprint 1 Jan - April labels Apr 7, 2023
@chriskuang4
Copy link
Contributor

Jared working on this now.

@chriskuang4 chriskuang4 moved this from In progress to To do in the Backlog Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023 Sprint 1 Jan - April 2023 Sprint 2 April - May bug Something isn't working
Projects
the Backlog
  
To do
Development

Successfully merging a pull request may close this issue.

4 participants