Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service invitation email template to include Login.gov information #1270

Closed
5 tasks done
Tracked by #1145
em-herrick opened this issue Mar 4, 2024 · 13 comments
Closed
5 tasks done
Tracked by #1145
Assignees

Comments

@em-herrick
Copy link
Contributor

em-herrick commented Mar 4, 2024

To complete:

  • Review existing email template
  • Revise to better convey information to both new and existing Notify.gov users

If new: create an account, then join a service.
If existing: just join new service

  • Add copy for new users about login.gov
  • Update copy in /app/config_files/templates.json
  • Run template update Flask command after deployment

New copy for "Service Invite" email being drafted here: https://docs.google.com/document/d/1gcj7ID_S5AgwhiRTfl9n6Z6959EvFUaH_FE81pszM7w/edit

@em-herrick
Copy link
Contributor Author

Create two new email templates

  • one for new users
  • one for existing users

@em-herrick
Copy link
Contributor Author

Update on comment above—Jon and Em have decided to start with one email template with an extra line of content for new users and see what kind of feedback we get.

@jskinne3
Copy link

The text of the email I see matches the drafted text google doc except for one part: the text under the horizontal line in the google doc is not included in the email.

This is the text missing from the email:

Notify.gov uses Login.gov to allow you to sign in safely. Login.gov is a secure sign in service to help you access participating government agencies’ digital touchpoints.

This is a screenshot of the email I see:
Screenshot 2024-04-17 at 10 11 22 AM

@em-herrick
Copy link
Contributor Author

em-herrick commented Apr 18, 2024

In addtion to John's comment above we also need to remove additional line of copy above Join Service link: Click this link to create an account on Notify.gov

Please review template code and verify new text has been fully copied over:

[Name] has invited you to collaborate on [service] on Notify.gov.

Notify.gov makes it easy to keep people updated by helping you send text messages.

Join Service
If you’re new to Notify.gov, you will first be directed to Login.gov to create an account with us.

This invitation will stop working at midnight tomorrow. This is to keep [service] secure.


Notify.gov uses Login.gov to allow you to sign in safely. Login.gov is a secure sign in service to help you access participating government agencies’ digital touchpoints.

@em-herrick em-herrick added the bug label Apr 18, 2024
@ccostino
Copy link
Contributor

ccostino commented May 1, 2024

This was merged and deployed to staging yesterday.

@jonathanbobel, @heyitsmebev, and/or @em-herrick, could you please check whenever you have a moment to see if the updates are now in place there? If so, they'll be ready for the next production release. 🙂 Thanks!

@em-herrick
Copy link
Contributor Author

em-herrick commented May 2, 2024

@ccostino yes, just did a QA—the email looks great.

But when I tried to finish setting up my profile account I got an error page.
Email (Service Link > Create Profile (filled in my name/phone number, clicked save> Got this first error page.
Screenshot 2024-05-02 at 9 41 31 AM

THEN, I used the back button> Create Profile: (edited my name)> clicked Save (again) and got this error page:

Screenshot 2024-05-02 at 9 43 43 AM

@ccostino
Copy link
Contributor

ccostino commented May 2, 2024

Well at least the email looks good! 😆 😭

Thanks for following up with these, @em-herrick! I think they might be separate errors and if so, we should create a new issue for those. I'll take a look to confirm.

@ccostino
Copy link
Contributor

ccostino commented May 2, 2024

Oh, wait @em-herrick - in that first message it looks like it was telling you that you can't accept the invite for another user. You were probably already logged in to the site in one account and tried to accept a service invite for a different account in the same window; had you done this in an incognito window or a different browser and signed in fully with the other user, it would have worked.

This is a known issue, where the user invite check is happening after we ask the user to fill in info, and we know it's not ideal.

@em-herrick
Copy link
Contributor Author

ah yes, duh. Let me check

@em-herrick
Copy link
Contributor Author

em-herrick commented May 2, 2024

@ccostino yes it worked well when I was in incognito mode! I need to remember this when doing QA. I see no issues now. :)

@ccostino
Copy link
Contributor

ccostino commented May 2, 2024

Woohoo! Okay - I think we have an issue already written up for the profile piece but if not we'll write one. In the meantime, we'll do a final test of this once we have our next prod deploy and close this out! Thanks, @em-herrick! 🙂

@ccostino
Copy link
Contributor

ccostino commented May 2, 2024

Invitation issue is now captured here! #1501

@ccostino
Copy link
Contributor

This is now live and the updated content is in place with the service invite email template! The other issue with the complete your profile step when accepting an invite for someone else is also done and in place.

I'm closing this out as I think all things are now accounted for! @em-herrick, please feel free to re-open or create a new issue if there are still any lingering problems or you notice something else. 🤞 that's not the case! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

5 participants