-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update service invitation email template to include Login.gov information #1270
Comments
Create two new email templates
|
Update on comment above—Jon and Em have decided to start with one email template with an extra line of content for new users and see what kind of feedback we get. |
The text of the email I see matches the drafted text google doc except for one part: the text under the horizontal line in the google doc is not included in the email. This is the text missing from the email:
|
In addtion to John's comment above we also need to remove additional line of copy above Please review template code and verify new text has been fully copied over:
|
This was merged and deployed to staging yesterday. @jonathanbobel, @heyitsmebev, and/or @em-herrick, could you please check whenever you have a moment to see if the updates are now in place there? If so, they'll be ready for the next production release. 🙂 Thanks! |
@ccostino yes, just did a QA—the email looks great. But when I tried to finish setting up my profile account I got an error page. THEN, I used the back button> Create Profile: (edited my name)> clicked Save (again) and got this error page: |
Well at least the email looks good! 😆 😭 Thanks for following up with these, @em-herrick! I think they might be separate errors and if so, we should create a new issue for those. I'll take a look to confirm. |
Oh, wait @em-herrick - in that first message it looks like it was telling you that you can't accept the invite for another user. You were probably already logged in to the site in one account and tried to accept a service invite for a different account in the same window; had you done this in an incognito window or a different browser and signed in fully with the other user, it would have worked. This is a known issue, where the user invite check is happening after we ask the user to fill in info, and we know it's not ideal. |
ah yes, duh. Let me check |
@ccostino yes it worked well when I was in incognito mode! I need to remember this when doing QA. I see no issues now. :) |
Woohoo! Okay - I think we have an issue already written up for the profile piece but if not we'll write one. In the meantime, we'll do a final test of this once we have our next prod deploy and close this out! Thanks, @em-herrick! 🙂 |
Invitation issue is now captured here! #1501 |
This is now live and the updated content is in place with the service invite email template! The other issue with the complete your profile step when accepting an invite for someone else is also done and in place. I'm closing this out as I think all things are now accounted for! @em-herrick, please feel free to re-open or create a new issue if there are still any lingering problems or you notice something else. 🤞 that's not the case! 🙂 |
To complete:
/app/config_files/templates.json
New copy for "Service Invite" email being drafted here: https://docs.google.com/document/d/1gcj7ID_S5AgwhiRTfl9n6Z6959EvFUaH_FE81pszM7w/edit
The text was updated successfully, but these errors were encountered: