Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: user email validation isn't wired up with Login.gov integration #1425

Closed
3 tasks
ccostino opened this issue Apr 15, 2024 · 0 comments · Fixed by #1428
Closed
3 tasks

Bug: user email validation isn't wired up with Login.gov integration #1425

ccostino opened this issue Apr 15, 2024 · 0 comments · Fixed by #1428
Assignees

Comments

@ccostino
Copy link
Contributor

ccostino commented Apr 15, 2024

When signing into Notify.gov, the system checks to see if the user's email needs to be verified and if so, redirects them to a verification page until they do.

With the switch to using Login.gov, this check is being skipped and we need to make sure it's wired up properly so that we continue having the 90 day verification checks with Notify.gov itself.

Implementation Sketch and Acceptance Criteria

  • Review the existing email verification check in our sign in code, which is tied to the custom app-specific sign in form
  • Add the verification check to the Login.gov sign in code (perhaps here?)
  • Test that the verification is working - you can do this locally by modifying the email_access_validated_at field in the users table for your user record to be some time in the past more than 90 days ago

Security Considerations

  • We need the email verification checks to continue working in Notify.gov even with the switch to Login.gov.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants