Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweener was removed from Gnome 3.37+ #905

Closed
voxik opened this issue Aug 4, 2020 · 3 comments
Closed

Tweener was removed from Gnome 3.37+ #905

voxik opened this issue Aug 4, 2020 · 3 comments

Comments

@voxik
Copy link

voxik commented Aug 4, 2020

Describe the bug

Tweener was removed from Gnome 3.37+:

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1200

and the replacement should be clutter animations.

As a workaround, removing const Tweener = imports.tweener.tweener; seems to be good start to make the gsconnect work, but there are still some errors reported, which requires fixing.

@andyholmes
Copy link
Collaborator

Thanks for reporting, should be fixed in acf0aa3

@voxik
Copy link
Author

voxik commented Aug 8, 2020

Thx, but there are still two places remaining:

$ grep -R Tweener
src/service/ui/messaging.js:const Tweener = imports.tweener.tweener;
src/service/ui/messaging.js:            Tweener.addTween(this._vadj, {
src/service/components/pulseaudio.js:const Tweener = imports.tweener.tweener;
src/service/components/pulseaudio.js:        Tweener.removeTweens(this);
src/service/components/pulseaudio.js:            Tweener.addTween(this, {
src/service/components/pulseaudio.js:            Tweener.addTween(this, {

@andyholmes
Copy link
Collaborator

These are shipped with GJS, so won't be affected by gnome-shell removing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants