Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong boolean expressions in ErrorDataSetRenderer.drawBubbles #558

Closed
protogenes opened this issue Nov 6, 2022 · 0 comments · Fixed by #596
Closed

wrong boolean expressions in ErrorDataSetRenderer.drawBubbles #558

protogenes opened this issue Nov 6, 2022 · 0 comments · Fixed by #596
Assignees
@wirew0rm

Comments

@protogenes
Copy link

The boolean expressions used in ErrorDataSetRenderer.drawBubbles are wrong and repeat/overlap so that only the first two braches ever match. Use conjunct clauses && to make distinct conditions for the branches.

Environment:

  • ChartFx version: master
  • attribution: IntelliJ
@wirew0rm wirew0rm self-assigned this Aug 9, 2023
wirew0rm added a commit that referenced this issue Aug 9, 2023
@wirew0rm
Renderer: Fix bubble chart error type handling
88ac0ed 
As reported by @protogenes, there was a misstake in the handling of the
Error type for BubbleCharts in the ErrorDataSetRender.

fixes #558
@wirew0rm wirew0rm mentioned this issue Aug 9, 2023
Merged
wirew0rm added a commit that referenced this issue Aug 9, 2023
@wirew0rm
Renderer: Fix bubble chart error type handling
110f856 
As reported by @protogenes, there was a misstake in the handling of the
Error type for BubbleCharts in the ErrorDataSetRender.

fixes #558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wirew0rm wirew0rm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renderer: Fix bubble chart error type handling fair-acc/chart-fx
2 participants
@wirew0rm @protogenes