Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated javadoc plugin #29

Merged
merged 1 commit into from Sep 12, 2019
Merged

updated javadoc plugin #29

merged 1 commit into from Sep 12, 2019

Conversation

ennerf
Copy link
Collaborator

@ennerf ennerf commented Sep 11, 2019

Apparently my mvn package issue from #27 was caused by a bug in the javadoc-plugin: https://issues.apache.org/jira/browse/MJAVADOC-581

I'm not sure why the path D:\Github\chart-fx would cause any issues, but updating to the latest version fixes it.

@wirew0rm wirew0rm merged commit 3584a24 into fair-acc:master Sep 12, 2019
@wirew0rm
Copy link
Member

Had to revert, because the newer javadoc plugin seems to enforce stricter rules.
See https://travis-ci.org/GSI-CS-CO/chart-fx/builds/584011977#L1733.
At the moment there is unfortuately no time to hunt all these javadoc errors.
Does javadoc generation work for you locally?

@ennerf
Copy link
Collaborator Author

ennerf commented Sep 12, 2019

Weird. Yes, it works locally for me. I tested it with

# mvn -v
Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T17:06:16+02:00)
Maven home: C:\Program Files\Java\apache-maven-3.6.2\bin\..
Java version: 11.0.1, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-11.0.1
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

@ennerf
Copy link
Collaborator Author

ennerf commented Sep 12, 2019

This is apparently a bug in javadoc: https://bugs.openjdk.java.net/browse/JDK-8212233. Some Java versions work, some don't.

On my computer:

  • Oracle JDK 11.0.1 [works]
  • Azul Zulu 11.0.2 [fails] (<- travis version)
  • Azul Zulu 11.0.4 [works]
  • Azul Zulu 12.0.2 [fails]

It was supposedly fixed in 11.0.3, but travis uses the broken 11.0.2.

It probably doesn't make sense to add until travis upgrades 👎 I'll deal with it locally until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants