Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct automatic module names #323

Merged
merged 1 commit into from Nov 27, 2020
Merged

Correct automatic module names #323

merged 1 commit into from Nov 27, 2020

Conversation

wirew0rm
Copy link
Member

Module names should not contain hyphens, so we cannot reuse our artifact
names. Instead introduce a new property which will be set in each
module.

fixes #321

Module names should not contain hyphens, so we cannot reuse our artifact
names. Instead introduce a new property which will be set in each
module.

fixes #321
Copy link
Member

@RalphSteinhagen RalphSteinhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 addresses issue #321

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #323 (ae9e489) into master (a36e779) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #323      +/-   ##
============================================
- Coverage     51.59%   51.58%   -0.01%     
+ Complexity     7266     7265       -1     
============================================
  Files           393      393              
  Lines         41072    41072              
  Branches       6611     6611              
============================================
- Hits          21191    21189       -2     
- Misses        18375    18376       +1     
- Partials       1506     1507       +1     
Impacted Files Coverage Δ Complexity Δ
.../main/java/de/gsi/chart/axes/spi/AbstractAxis.java 76.41% <0.00%> (-0.30%) 183.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36e779...ae9e489. Read the comment docs.

@wirew0rm wirew0rm merged commit 20ae707 into master Nov 27, 2020
@wirew0rm wirew0rm deleted the fixAutoModuleName branch November 27, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hyphen module name breaks module based projects
2 participants