Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csvw-check validating windows behaviour tests #851

Open
4 of 6 tasks
CharlesRendle opened this issue Jul 13, 2023 · 0 comments
Open
4 of 6 tasks

csvw-check validating windows behaviour tests #851

CharlesRendle opened this issue Jul 13, 2023 · 0 comments
Assignees
Labels

Comments

@CharlesRendle
Copy link
Contributor

CharlesRendle commented Jul 13, 2023

Ticket is a follow-up to #850 in which we aim to remove csvlint validation from the behaviour tests when run in a windows environment.

After completeing #850 we should have a function in (renamed) csvlint.py from csvcubed-devtools which uses the csvw-check docker image when running behaviour tests in a linux environment but reverting to csvlint when not (aka windows). Any issues that arose because of this change should also have been addressed before starting the implementation into windows tests.

  • Alter the function written in csvw-check validating linux behaviour tests #850 so that the else: statement now runs csvw-check as a command line tool. This should follow the format of the "not docker" section of csvw-checks readme. Also ensuring that logs are captured in the same fashion as they are from the docker version.

  • Change windows-testing-setup.ps1 so that we are no longer installing ruby, bundle, i18n, csvlint, etc

  • Instead, we want to install and unpack the csvw-check zip. Make sure that this is in the correct location (known and navigable location)

    • Do we need to add csvw-check to path so it can be run from anywhere?
    • Do we need to install scala (like we are with ruby for csvlint) - if yes, this needs to be part of the csvw-check installation changes in windows-testing-setup.ps1 and presumably reusable-test.yaml should also have a scala version variable?
  • reusable-test.yaml should no longer have a ruby version variable (ln:24)

  • Once you think all the changes have been made, push to a draft PR and look at the behaviour tests running on windows to see whether they are being executed as expected.

  • Replace csvlint link in useful links section of developer.md with a link to csvw-check's github page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants