You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ticket is a follow-up to #850 in which we aim to remove csvlint validation from the behaviour tests when run in a windows environment.
After completeing #850 we should have a function in (renamed) csvlint.py from csvcubed-devtools which uses the csvw-check docker image when running behaviour tests in a linux environment but reverting to csvlint when not (aka windows). Any issues that arose because of this change should also have been addressed before starting the implementation into windows tests.
Alter the function written in csvw-check validating linux behaviour tests #850 so that the else: statement now runs csvw-check as a command line tool. This should follow the format of the "not docker" section of csvw-checks readme. Also ensuring that logs are captured in the same fashion as they are from the docker version.
Change windows-testing-setup.ps1 so that we are no longer installing ruby, bundle, i18n, csvlint, etc
Instead, we want to install and unpack the csvw-check zip. Make sure that this is in the correct location (known and navigable location)
Do we need to add csvw-check to path so it can be run from anywhere?
Do we need to install scala (like we are with ruby for csvlint) - if yes, this needs to be part of the csvw-check installation changes in windows-testing-setup.ps1 and presumably reusable-test.yaml should also have a scala version variable?
reusable-test.yaml should no longer have a ruby version variable (ln:24)
Once you think all the changes have been made, push to a draft PR and look at the behaviour tests running on windows to see whether they are being executed as expected.
Replace csvlint link in useful links section of developer.md with a link to csvw-check's github page.
The text was updated successfully, but these errors were encountered:
Ticket is a follow-up to #850 in which we aim to remove csvlint validation from the behaviour tests when run in a windows environment.
After completeing #850 we should have a function in (renamed)
csvlint.py
fromcsvcubed-devtools
which uses the csvw-check docker image when running behaviour tests in a linux environment but reverting to csvlint when not (aka windows). Any issues that arose because of this change should also have been addressed before starting the implementation into windows tests.Alter the function written in csvw-check validating linux behaviour tests #850 so that the
else:
statement now runs csvw-check as a command line tool. This should follow the format of the "not docker" section of csvw-checks readme. Also ensuring that logs are captured in the same fashion as they are from the docker version.Change
windows-testing-setup.ps1
so that we are no longer installing ruby, bundle, i18n, csvlint, etcInstead, we want to install and unpack the csvw-check zip. Make sure that this is in the correct location (known and navigable location)
windows-testing-setup.ps1
and presumablyreusable-test.yaml
should also have a scala version variable?reusable-test.yaml
should no longer have a ruby version variable (ln:24)Once you think all the changes have been made, push to a draft PR and look at the behaviour tests running on windows to see whether they are being executed as expected.
Replace csvlint link in useful links section of
developer.md
with a link to csvw-check's github page.The text was updated successfully, but these errors were encountered: