Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attribute describes observations #583 revisit #863

Open
canwaf opened this issue Jul 28, 2023 · 0 comments
Open

attribute describes observations #583 revisit #863

canwaf opened this issue Jul 28, 2023 · 0 comments

Comments

@canwaf
Copy link
Member

canwaf commented Jul 28, 2023

Instead of requiring that all attributes need to be attached to an observation column in a pivoted dataset, attributes which are not so attached should be present on all observations.

The current mechanism for attaching attributtions to observations is in observations.py.

For attributes in a pivoted dataset we should support the following.

  • "describes_observations": "a value" single observation column, applies to only that column
  • "describes_observations": False the column applies to all observations

Update the error message for when describes_observations is either not set in pivoted datasets, or doesn't match a column, the user is told to make sure the column is defined correctly, or the the value to false so that the attribute is applicable to all observations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants