Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There is a conflict in logging and transformer's logging #1

Closed
JHR0717 opened this issue Oct 19, 2020 · 5 comments
Closed

There is a conflict in logging and transformer's logging #1

JHR0717 opened this issue Oct 19, 2020 · 5 comments
Assignees
@felixwzh

Comments

@JHR0717
Copy link

JHR0717 commented Oct 19, 2020 •
edited

  • The package transfomers has the utils files with logging.py which confilts with the logging module.

So,we maybe need to change the import logging to import logging as log (rename the logging)
@felixwzh
Copy link
Collaborator

Thank you for pointing it out! Addressed in 2838a4c

@JHR0717
Copy link
Author

JHR0717 commented Oct 20, 2020 via email

@JHR0717
Copy link
Author

JHR0717 commented Oct 21, 2020 via email •
edited

@jiaaoc jiaaoc reopened this Oct 21, 2020
@felixwzh
Copy link
Collaborator

Hi, we set k=20 just to get top-20 neighbors, and during training we can set num_knn_k in [1,20].

@JHR0717
Copy link
Author

JHR0717 commented Oct 22, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixwzh felixwzh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@felixwzh @jiaaoc @JHR0717