New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support in RT Trainer for multiple entities. #159
Conversation
Solving GT4SD#143. Signed-off-by: Nicolai Ree <Ree@sunray>
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, great stuff @NicolaiRee! I expanded the docstrings a bit, see my comments. The only remaining thing to add is a test for this new feature (see src/gt4sd/training_pipelines/tests
src/gt4sd/algorithms/conditional_generation/regression_transformer/implementation.py
Show resolved
Hide resolved
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
|
Hey @NicolaiRee, |
Hey @jannisborn, I have followed the direct instruction about the email and made the issue for getting on the contribution list, but I do not know why the verification still fails. Do you have any suggestions? |
I think the problem is the first commit that is associated to an unverified account (see image). At this point it's probably easy to:
|
Okay lets try that |
Solving #143 by expanding the Regression Transformer trainer to support multi-entity discriminations, i.e., support the multientity_cg collator from the RT repo.
Signed-off-by: Nicolai Ree Ree@sunray