Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support in RT Trainer for multiple entities. #159

Closed

Conversation

NicolaiRee
Copy link
Contributor

Solving #143 by expanding the Regression Transformer trainer to support multi-entity discriminations, i.e., support the multientity_cg collator from the RT repo.

Signed-off-by: Nicolai Ree Ree@sunray

Solving GT4SD#143.

Signed-off-by: Nicolai Ree <Ree@sunray>
@cla-bot
Copy link

cla-bot bot commented Oct 28, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@NicolaiRee NicolaiRee marked this pull request as ready for review October 28, 2022 16:23
@NicolaiRee NicolaiRee closed this Oct 28, 2022
@NicolaiRee NicolaiRee reopened this Oct 28, 2022
@NicolaiRee NicolaiRee marked this pull request as draft October 28, 2022 16:25
@drugilsberg drugilsberg requested review from drugilsberg and jannisborn and removed request for drugilsberg October 28, 2022 20:44
Copy link
Contributor

@jannisborn jannisborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, great stuff @NicolaiRee! I expanded the docstrings a bit, see my comments. The only remaining thing to add is a test for this new feature (see src/gt4sd/training_pipelines/tests

@cla-bot
Copy link

cla-bot bot commented Nov 1, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 1, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 4, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot
Copy link

cla-bot bot commented Nov 7, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Nicolai Ree.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@jannisborn
Copy link
Contributor

Hey @NicolaiRee,
Cool, the tests are passing now. Did you follow the steps suggested by the CLA bot to make the verification checks passing?

@NicolaiRee
Copy link
Contributor Author

Hey @jannisborn, I have followed the direct instruction about the email and made the issue for getting on the contribution list, but I do not know why the verification still fails. Do you have any suggestions?

@drugilsberg
Copy link
Contributor

Hey @jannisborn, I have followed the direct instruction about the email and made the issue for getting on the contribution list, but I do not know why the verification still fails. Do you have any suggestions?

I think the problem is the first commit that is associated to an unverified account (see image).
image

At this point it's probably easy to:

  • close this PR
  • fork gt4sd:main again and apply all changes in a single commit with the verified account
  • open another PR

@NicolaiRee
Copy link
Contributor Author

Okay lets try that

@NicolaiRee NicolaiRee closed this Nov 7, 2022
@NicolaiRee NicolaiRee deleted the multiple_entities_RT_trainer branch November 7, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants