Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when inventory is open #473

Open
4 tasks done
Ciubix8513 opened this issue May 10, 2024 · 11 comments
Open
4 tasks done

Crash when inventory is open #473

Ciubix8513 opened this issue May 10, 2024 · 11 comments

Comments

@Ciubix8513
Copy link

Your GTNH Discord Username

@Ciubix8513

Mod Version

1.0.0-alpha40

Java Version

Java 21

Graphics Card Vendor

AMD/ATI

Bug Report

hs_err_pid239684.log

Mod List or GTNH Pack Version

gtnh-2.6.0 + SkinPort

Final Checklist

  • I have searched the issues and haven't found a similar issue.
  • I have read the known incompatibilities and this is not related to one of those.
  • I am running an officially released version. (Or, if I've compiled it myself I plan to fix the issue)
  • This issue is not related to a feature that is disabed by default - Shaders, MCPF, etc. [They'll be enabled when they're ready for testing]
@mitchej123
Copy link
Collaborator

This doesn't seem very angelica related looking at the stacktrace

Current thread (0x00007caa9c0190f0):  JavaThread "Client thread"        [_thread_in_native, id=239685, stack(0x00007caaa2700000,0x00007caaa2800000) (1024K)]

Stack: [0x00007caaa2700000,0x00007caaa2800000],  sp=0x00007caaa27fd368,  free space=1012k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [libc.so.6+0x167637]
Java frames: (J=compiled Java code, j=interpreted, Vv=VM code)
J 50374  org.lwjgl.opengl.GL15C.nglGenBuffers(IJ)V (0 bytes) @ 0x00007caa8f38647c [0x00007caa8f386420+0x000000000000005c]
J 62085 c2 net.minecraft.client.model.ModelRenderer.func_78788_d(F)V (85 bytes) @ 0x00007caa918646a4 [0x00007caa91864220+0x0000000000000484]
J 55170 c2 net.minecraft.client.model.ModelRenderer.func_78785_a(F)V (411 bytes) @ 0x00007caa912c9824 [0x00007caa912c86a0+0x0000000000001184]
J 77780 c2 emt.client.model.ModelWings.func_78088_a(Lnet/minecraft/entity/Entity;FFFFFF)V (43 bytes) @ 0x00007caa8fd87d48 [0x00007caa8fd87b40+0x0000000000000208]
J 66505 c2 net.minecraft.client.renderer.entity.RendererLivingEntity.func_76986_a(Lnet/minecraft/entity/EntityLivingBase;DDDFF)V (1321 bytes) @ 0x00007caa90e6eb08 [0x00007caa90e6cf80+0x0000000000001b88]
J 72274 c2 lain.mods.skinport.impl.forge.SkinPortRenderPlayer.func_76986_a(Lnet/minecraft/client/entity/AbstractClientPlayer;DDDFF)V (456 bytes) @ 0x00007caa9181bbd4 [0x00007caa9181b0a0+0x0000000000000b34]
J 71214 c2 net.minecraft.client.renderer.entity.RenderPlayer.func_76986_a(Lnet/minecraft/entity/Entity;DDDFF)V (18 bytes) @ 0x00007caa8fc800fc [0x00007caa8fc800a0+0x000000000000005c]
J 56000 c2 net.minecraft.client.renderer.entity.RenderManager.func_147939_a(Lnet/minecraft/entity/Entity;DDDFFZ)Z (285 bytes) @ 0x00007caa9147431c [0x00007caa91474060+0x00000000000002bc]
J 74651 c2 net.minecraft.client.gui.inventory.GuiInventory.func_147046_a(IIIFFLnet/minecraft/entity/EntityLivingBase;)V (275 bytes) @ 0x00007caa91369be4 [0x00007caa91368b20+0x00000000000010c4]
J 74685 c2 net.minecraft.client.gui.inventory.GuiInventory.func_146976_a(FII)V (98 bytes) @ 0x00007caa8efd32a0 [0x00007caa8efd2de0+0x00000000000004c0]
J 73498 c2 net.minecraft.client.gui.inventory.GuiContainer.func_73863_a(IIF)V (612 bytes) @ 0x00007caa8ee4aa7c [0x00007caa8ee4a280+0x00000000000007fc]
J 74684 c2 net.minecraft.client.gui.inventory.GuiInventory.func_73863_a(IIF)V (20 bytes) @ 0x00007caa8f213aec [0x00007caa8f213920+0x00000000000001cc]
J 73295 c2 net.minecraft.client.renderer.EntityRenderer.func_78480_b(F)V (910 bytes) @ 0x00007caa8ed0d4cc [0x00007caa8ed0c0e0+0x00000000000013ec]
J 59945 c2 net.minecraft.client.Minecraft.func_71411_J()V (783 bytes) @ 0x00007caa906c067c [0x00007caa906bf060+0x000000000000161c]
J 74578% c2 net.minecraft.client.Minecraft.func_99999_d()V (246 bytes) @ 0x00007caa8e9f5d2c [0x00007caa8e9f5cc0+0x000000000000006c]
j  net.minecraft.client.main.Main.main([Ljava/lang/String;)V+1012
j  java.lang.invoke.LambdaForm$DMH+0x00007caa1c00cc00.invokeStatic(Ljava/lang/Object;Ljava/lang/Object;)V+10 java.base@21.0.3
j  java.lang.invoke.LambdaForm$MH+0x00007caa1c10b000.invoke(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;+33 java.base@21.0.3
J 3935 c1 jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object; java.base@21.0.3 (92 bytes) @ 0x00007caa876b808c [0x00007caa876b63c0+0x0000000000001ccc]
J 3934 c1 java.lang.reflect.Method.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object; java.base@21.0.3 (108 bytes) @ 0x00007caa876b49f4 [0x00007caa876b44c0+0x0000000000000534]
j  net.minecraft.launchwrapper.Launch.rfb$realLaunch([Ljava/lang/String;)V+887
j  net.minecraft.launchwrapper.Launch.launch([Ljava/lang/String;)V+2
j  net.minecraft.launchwrapper.Launch.main([Ljava/lang/String;)V+29
j  java.lang.invoke.LambdaForm$DMH+0x00007caa1c00cc00.invokeStatic(Ljava/lang/Object;Ljava/lang/Object;)V+10 java.base@21.0.3
j  java.lang.invoke.LambdaForm$MH+0x00007caa1c10b000.invoke(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;+33 java.base@21.0.3
j  java.lang.invoke.Invokers$Holder.invokeExact_MT(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object;+20 java.base@21.0.3
j  jdk.internal.reflect.DirectMethodHandleAccessor.invokeImpl(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+55 java.base@21.0.3
j  jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+23 java.base@21.0.3
j  java.lang.reflect.Method.invoke(Ljava/lang/Object;[Ljava/lang/Object;)Ljava/lang/Object;+102 java.base@21.0.3
j  com.gtnewhorizons.retrofuturabootstrap.Main.main([Ljava/lang/String;)V+406
j  java.lang.invoke.LambdaForm$DMH+0x00007caa1c00cc00.invokeStatic(Ljava/lang/Object;Ljava/lang/Object;)V+10 java.base@21.0.3
j  java.lang.invoke.LambdaForm$MH+0x00007caa1c10a400.invokeExact_MT(Ljava/lang/Object;Ljava/lang/Object;Ljava/lang/Object;)V+19 java.base@21.0.3
j  org.prismlauncher.launcher.impl.StandardLauncher.launch()V+210
j  org.prismlauncher.EntryPoint.listen()Lorg/prismlauncher/EntryPoint$ExitCode;+288
j  org.prismlauncher.EntryPoint.main([Ljava/lang/String;)V+0
v  ~StubRoutines::call_stub 0x00007caa8e25fcc6

@mitchej123
Copy link
Collaborator

Seems more driver related.... crashing in nglGenBuffers is odd

@Ciubix8513
Copy link
Author

I did not have this issue on 2.5.1, and i don't believe there was a new driver version

@mitchej123
Copy link
Collaborator

I'm still not seeing anything Angelica specific or related in there

@Caedis
Copy link
Member

Caedis commented May 10, 2024

Might be SkinPort + EMT or an interaction with of those 2 + Angelica

@mitchej123
Copy link
Collaborator

2muchFPS

@Ciubix8513
Copy link
Author

Ciubix8513 commented May 17, 2024

I finally got arround to testing the cause of it. It is not Skinport, i removed it and the crash still persists and i also upgraded angelica to the latest version just in case and the crash is still there.

Also it happens when rendering the player, be that inventory, in F5 or in a wireless crafting terminal

Here's the latest log, with angelica 1.0.0-alpha50, and skinport disabled:

hs_err_pid80773.log

@Caedis
Copy link
Member

Caedis commented May 17, 2024

Do you happen to have a EMT wing/jetpack?

@Ciubix8513
Copy link
Author

Yes, I am using nano wings

@mitchej123
Copy link
Collaborator

The NanoWing renderer seems to be allocating a new Renderer each tick... which on vanilla seems to create a new DisplayList each tick..... but with Angelica it creates a new VBO each tick... and apparently the driver eventually gets sick of that and crashes.

I'm not sure how the display list spam works, and not the VBO spam.... I also don't see any proper cleanup of it.... It's a bug/leak in EMT that needs to be resolved.

@Ciubix8513
Copy link
Author

I see...

I had a look at the EMT code, and tried to fix that, but i don't have enough knowledge of how it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants