Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everburn Urn fix #681

Closed
Technus opened this issue Aug 24, 2016 · 13 comments
Closed

Everburn Urn fix #681

Technus opened this issue Aug 24, 2016 · 13 comments

Comments

@Technus
Copy link
Contributor

Technus commented Aug 24, 2016

GaeaKat/Thaumic_Exploration#40

Dream would be nice if u could branch and compile with the changes.

afaik you still have to import some TC API file.

@Dream-Master
Copy link
Member

Ok will do.

@Dream-Master Dream-Master added this to the 1.0.9.2 milestone Aug 24, 2016
@Dream-Master Dream-Master self-assigned this Aug 24, 2016
@Dream-Master
Copy link
Member

@tvanderka
Copy link

You made a typo with "ticks=0" being in the wrong place, it disabled the urn completely. Move it up 1 line and it works fine.

I also suggest replacing "extends TileVisRelay" with "extends TileThaumcraft" so it does not act like a vis relay, works better this way.

@Technus
Copy link
Contributor Author

Technus commented Aug 25, 2016

@Dream-Master
Copy link
Member

Merged will compile anew version.

@Dream-Master
Copy link
Member

@Technus
Copy link
Contributor Author

Technus commented Aug 25, 2016

Seems fixed, (i have that issue in my base on live server i could test on that when the updates comes)

@Walkman100
Copy link

Walkman100 commented Jan 1, 2018

It's fixed as in the client no longer crashes, but on my setup with Thaumic Exploration v1.1.57 it still acts as a vis relay. It draws CV in blobs like any other machine (Infernal Furnace, Focal Manipulator e.t.c.), but it still connects to vis relays.

I can provide version info/logs/screenshots if that'd help, but I doubt it's anything funny on my end, probably a simple line of code or two to remove in the mod's source (sorry not a java coder or I'd see if I could make a PR).

@Dream-Master
Copy link
Member

Dream-Master commented Jan 1, 2018

Try with version 1.1.71 @Walkman100

@Dream-Master
Copy link
Member

@Walkman100
Copy link

Walkman100 commented Jan 4, 2018

using Thaumic-Exploration-.1.7.10.1.1.71-0.jar from the zip above I get this loading a world:

image
(was previously using ThaumicExploration-1.7.10-1.1-57.jar

I click yes and the world loads fine, however after staring at an everburn urn seemingly working normally (and not acting as a vis relay) after a few seconds my game crashed (looks like a generic error to me). (OpenEye report: http://openeye.openmods.info/crashes/1714de7b6bc68c9687f4c01bc2e2131a)

Upon reloading the world and removing and replacing the urns, all seems well. The urns now only store 2 buckets of lava and sputter annoying particles even when it's doing nothing though... they also seem to produce half the amount of lava...

Not sure if I'll use it on my server, but thanks for the option. You should upload these builds (57 and 71) to curse, I'm sure others will appreciate not having to dig through GitHub to find them :D

@Dream-Master
Copy link
Member

Ok thanks for testings but i am not the Mod Author of the original Mod not the Mod Author make the fix. I can link the version.

@Dream-Master
Copy link
Member

https://github.com/KryptonCaptain/Thaumic_Exploration/releases
@Walkman100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants