Check whether domains are allowed on renewals #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yveslaroche
force-pushed
the
use-allow-domain-for-renewals
branch
2 times, most recently
from
7ec3d80
to
4e8efe4
Compare
|
+1 Badly need this feature. |
|
+1 Totally makes sense. |
yveslaroche
force-pushed
the
use-allow-domain-for-renewals
branch
from
4e8efe4
to
030de79
Compare
GUI
added a commit
that referenced
this pull request
Sep 30, 2019
Since renewal calls to the `allow_domain` callback won't have SSL options passed in, document this fact and also pass a boolean argument to this callback method so logic can vary depending on renewals or not. Building on top of #176
|
Apologies on the delay, but thanks for this! This is now part of the v0.13.0 release. I made some further tweaks and added tests in 544c53c. The one things to possibly note is that when |
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call allow_domain on renewals, so that it is possible to avoid renewing domains that are not allowed anymore e.g. have expired, dns doesn't resolve anymore etc. using custom code in the allow_domain function.
Thanks to @brianlund who posted this in #150
This fixes #101 and at least partially also #150