Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 5.1 and other channel layouts #28

Closed
GWBasic opened this issue Apr 23, 2023 · 2 comments · Fixed by #29
Closed

Support 5.1 and other channel layouts #28

GWBasic opened this issue Apr 23, 2023 · 2 comments · Fixed by #29

Comments

@GWBasic
Copy link
Owner

GWBasic commented Apr 23, 2023

This website explains the channel layout of 5.1 wav files: https://www.jensign.com/bdp95/7dot1voiced/index.html

It then links to a more detailed document from Microsoft about varying channel layout. (IE, how to disambiguate from 3.1 versus quad: https://learn.microsoft.com/en-us/previous-versions/windows/hardware/design/dn653308(v=vs.85)?redirectedfrom=MSDN

One important change needed in wave_stream is supporting channelMask

@GWBasic
Copy link
Owner Author

GWBasic commented Apr 23, 2023

Converted the headers to handle WAVEFORMATEX. Currently refactoring so that reading/writing works with a SamplesByChannel struct that specifies the sample for each channel by speaker location instead of numerical index.

Writing is almost completed (just need to update tests.) Need to update reading.

@GWBasic GWBasic linked a pull request Apr 30, 2023 that will close this issue
@GWBasic
Copy link
Owner Author

GWBasic commented Apr 30, 2023

Started updating the example: GWBasic/wave_stream_example#1

Changes needed:

  • Need to test a proper 5.1 wav in Kodi
  • Need to update sample code in lib.rs
  • Need to publish a new revision to crates.io
  • Need to update the sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant