Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to update versions in mypy hook's additional_dependencies #24

Open
macintacos opened this issue Mar 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@macintacos
Copy link

macintacos commented Mar 4, 2024

This plugin is great, thanks for making it!

One thing that would put it over the top for me would be to add the ability to update mypy's additional_dependencies array to match the versions in the lock file as well. Any chance this could be something that is added to this plugin? It feels like a natural extension of this project.

@GabDug GabDug added the enhancement New feature or request label Mar 23, 2024
@GabDug
Copy link
Owner

GabDug commented Mar 24, 2024

Hey @macintacos!

This is indeed a natural extension of the project, and was already an area of improvement.

For a first version, I think I'll just go through additional_dependencies of all hooks, and update all requirements to be the exact pinned version of the package.
In the future, we may want to map PDM/Poetry dependency group to a hook's additional_dependencies, so that addition and deletion of packages are handled as well.

I don't use the mypy hook or additional_dependencies, would you mind sharing one of your configuration as a test case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants