Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "vector-builder" #88

Closed
nikita-volkov opened this issue May 18, 2017 · 1 comment
Closed

Use "vector-builder" #88

nikita-volkov opened this issue May 18, 2017 · 1 comment

Comments

@nikita-volkov
Copy link
Contributor

According to the benchmark, it's several times faster than the current implementation and it doesn't require the FoldM abstraction, Fold is enough.

Following are the benchmark results:

benchmarking vector-builder
time                 82.43 μs   (82.16 μs .. 82.84 μs)
                     1.000 R²   (1.000 R² .. 1.000 R²)
mean                 82.79 μs   (82.41 μs .. 83.38 μs)
std dev              1.579 μs   (1.104 μs .. 2.078 μs)
variance introduced by outliers: 14% (moderately inflated)

benchmarking default
time                 217.1 μs   (211.7 μs .. 223.8 μs)
                     0.994 R²   (0.990 R² .. 0.998 R²)
mean                 212.8 μs   (210.2 μs .. 216.8 μs)
std dev              10.99 μs   (6.764 μs .. 16.42 μs)
variance introduced by outliers: 50% (moderately inflated)
Gabriella439 added a commit that referenced this issue May 19, 2017
This improves the performance of the `vector` utility and allows it to become a
pure `Fold`
@Gabriella439
Copy link
Owner

Take a look at #89 and let me know if that is what you had in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants