Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapseClusters in R 4.3 #2

Open
gsudre opened this issue May 17, 2023 · 3 comments
Open

collapseClusters in R 4.3 #2

gsudre opened this issue May 17, 2023 · 3 comments

Comments

@gsudre
Copy link

gsudre commented May 17, 2023

Hi Gabriel. Great tool! It looks like collapseClusters in breaking in 4.3. Probably due to the && in vapply throwing an error now (https://cran.r-project.org/doc/manuals/r-release/NEWS.html).

If I change that last idx assignment to:

idx = vapply(clCount, function(x) { length(x) > 0 && all(x > 0) }, logical(1))

It should still behave the same, right? Thanks!

@GabrielHoffman
Copy link
Owner

Do you have a minimal reproducible example of the problem? I'm not able to find an issue

@GabrielHoffman
Copy link
Owner

I updated the package with this fix

I also updated the website so the search works now

Gabriel

@gsudre
Copy link
Author

gsudre commented May 17, 2023

Thanks Gabriel! Yes, that works. Let me know if you still need a reproducible example and I'll send it. It can be seen just with a simple vector sent to vapply. When in previous versions it'd throw a warning, now it throws an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants