Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some UI to shader nodes in the NodeEditor to represent the available plugs #130

Closed
bentoogood opened this issue Apr 4, 2013 · 10 comments
Assignees

Comments

@bentoogood
Copy link
Contributor

Will help users be aware of available plugs and could offer a mechanism for creating nodes already connected to those plugs.

@ghost ghost assigned johnhaddon Apr 19, 2013
@bentoogood
Copy link
Contributor Author

And when I say plugs I mean plugs that have a nodule and therefore are 'plug-able'

if you know what I mean....

@johnhaddon
Copy link
Member

I seem to remember we agreed that this would be done in Graffer in the short term? Can I move it out of the milestone?

@bentoogood
Copy link
Contributor Author

Hmm - looking at the graffer tickets, we agreed to do it gaffer side :)

But it is low priority.
Something we can come back to later.

@johnhaddon
Copy link
Member

I thought in the last skyping we said that since we already had the input creation logic in Graffer (for the right click menu), that we would do it there for now?

@bentoogood
Copy link
Contributor Author

Let's confirm on thursday. But either way, it's one to ignore for now.

@johnhaddon
Copy link
Member

We forgot to discuss this one in the conference call - any update from your side?

@bentoogood
Copy link
Contributor Author

No update - we can make sure we get David in on next conversation.
Any pressing need, or are you just checking over all tickets?

@johnhaddon
Copy link
Member

No pressing need - I was just giving the tickets a once over and realised we forgot to clarify on this one.

@bentoogood
Copy link
Contributor Author

This just came up with Yuta, so bumping priority

@bentoogood
Copy link
Contributor Author

Agreed plan:

  • First pass:
    • Add row in NodeEditor to represent eacg available pluggable plug
    • Add gui element to row that shows the name of the input plug ( or 'none' if there is no connection )
    • Add gui element (button) to row that if clicked will select the input node in and make it active in the NodeEditor
    • Should it be active in any Viewers too? Just do what ever a double click does?
  • Second pass (on backburner for now):
    • Add gui element to row that if clicked presents list of nodes available for connection (filtered by plug type)
    • If item in list is clicked, create that node and connect the output to the current node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants