GUI : Apply user defaults to new Scripts. #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| scriptNode = Gaffer.ScriptNode() | ||
| Gaffer.NodeAlgo.applyUserDefaults( scriptNode ) | ||
| self.root()["scripts"].addChild( scriptNode ) | ||
| del scriptNode |
There was a problem hiding this comment.
Why do we need to del scriptNode here, but not in FileMenu.new()?
There was a problem hiding this comment.
Good question. I have to admit I put it there out of superstition after seeing the existing del just above it in the same file. I've now got to the bottom of why that was there, and removed it in 1f9248c - there's some further explanation in the commit message.
This makes it easier to set defaults for frame range etc, using something like the following from a startup file : ``` Gaffer.Metadata.registerValue( Gaffer.ScriptNode, "frameRange.start", "userDefault", 1001 ) Gaffer.Metadata.registerValue( Gaffer.ScriptNode, "frameRange.end", "userDefault", 2000 ) ```
This should have been removed in 45a0ff5. Prior to that commit, the `_run()` method performed a check that all ScriptNodes had been destroyed before shutdown, and it was therefore necessary to explicitly drop the reference held by the local `scriptNode` variable. Following that commit, the checks are performed after `_run()` returns, after the `scriptNode` variable has left scope anyway.
johnhaddon
force-pushed
the
scriptNodeDefaults
branch
from
5a094ca
to
1f9248c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to set defaults for frame range etc, using something like the following from a startup file :