Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompoundNumericPlugs serialise redundantly #2

Closed
bentoogood opened this issue Mar 27, 2013 · 0 comments
Closed

CompoundNumericPlugs serialise redundantly #2

bentoogood opened this issue Mar 27, 2013 · 0 comments
Labels
core Issues with core Gaffer functionality

Comments

@bentoogood
Copy link
Contributor

We don't need the last two lines :

__children["Displays"]["__uiPosition"].setValue( IECore.V2f( 5.65656, 11.4747 ) )
__children["Displays"]["__uiPosition"]["x"].setValue( 5.6565647125244141 )
__children["Displays"]["__uiPosition"]["y"].setValue( 11.474745750427246 )
@ghost ghost assigned bentoogood and johnhaddon Mar 27, 2013
johnhaddon referenced this issue in johnhaddon/gaffer Jul 2, 2013
A medley of fixes relating to the SplinePlug :

- Implemented SplinePlug::createCounterpart()
- Made CompoundPlugSerialiser public so it can be used by derived classes
- Fixed SplinePlug serialisation.
- Removed redundant setValue() calls in ValuePlug serialisation - values are now set only on the leaf plugs. Fixes #2.

Among other things this now allows SplinePlugs to be happily saved and loaded, cut and pasted, and promoted to Boxes.
@ericmehl ericmehl mentioned this issue May 10, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues with core Gaffer functionality
Projects
None yet
Development

No branches or pull requests

2 participants