Rename UndoContext -> UndoScope #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids confusion with the Context class, and brings the name into line with other scoping classes like `DirtyPropagationScope` and `Context::EditableScope`. Breaking change : - Renamed UndoContext UndoScope
This allows old python scripts to continue to function until they are updated.
|
@danieldresser or @mattigruener can you fixup the IERendering bit? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discussion over the naming of
Context::EditableScopereminded me that we've been meaning to change this misleading UndoContext name for a long time now. It has nothing to do with Contexts in the Gaffer sense, and the UndoScope name makes it much clearer that it behaves like other scopes in gaffer.This is a binary and source compatibility break, but I've included a startup file which provides temporary backwards compatibility for python scripts. In practice, I believe the IE codebase only has a single use of UndoContext from C++, in IEMayaRendering::PaintCommand. If it's not possible to update this I could provide a compatibility header, but I'm hoping that won't be necessary...