ContextProcessor refactoring #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just calls the existing `removeMatching()` method on the underlying Context. Also fixed comment.
This allows us to stop using the deprecated Context::Borrowed constructor. Breaking Changes : - ContextProcessor : Changed signature of `processContext()`.
This simplifies derived class implementations. In general I'm trying to move towards this pattern for all DependencyNode subclasses, rather than having everything reimplement the base class `affects()` method directly. Breaking Changes : - ContextProcessor : Added `affectsContext()` pure virtual method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tidies things up a little, and moves us closer to being able to remove the deprecated
Ownershipargument from the Context copy constructor. Once we can do that, we can look at optimisingContext::EditableScopefurther.