Metadata matching improvements #2536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't allow '*' to match the '.' in a plug path. This mimics how '*' doesn't match '/' in a glob match or in the PathMatcher. - Allow '...' to match any number of plug path elements, in the same way a PathMatcher does. Breaking Change : - Changed metadata wildcard matching rules.
This has been deprecated for almost 3 years, and recent improvements in metadata matching should have rendered it totally unnecessary. This removes one of the main hurdles in completing GafferHQ#707. Breaking Change : - Removed `PlugValueWidget.registerCreator()`. Use metadata instead.
johnhaddon
force-pushed
the
metadataMatchers
branch
from
53e8b5a
to
7b9837e
Compare
johnhaddon
added a commit
to johnhaddon/gaffer
that referenced
this pull request
May 2, 2018
Fixes the following test failure :
```
======================================================================
FAIL: testSplineParameterUserDefaults (GafferOSLUITest.OSLShaderUITest.OSLShaderUITest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/john/dev/build/gaffer/python/GafferOSLUITest/OSLShaderUITest.py", line 110, in testSplineParameterUserDefaults
self.assertEqual( s["parameters"]["spline"]["interpolation"].getValue(), Gaffer.SplineDefinitionInterpolation.Linear )
AssertionError: 1 != Gaffer._Gaffer.SplineDefinitionInterpolation.Linear
```
This appears to have been broken by GafferHQ#2536, which was pull-requested before the test was added, but merged after the test had been merged. Something to bear in mind if we keep PRs open for a long time - the Travis results are only valid at the point they were run, and aren't to be trusted after subsequent changes to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the changes Daniel needs for #2508 and also removes the deprecated
PlugValueWidget.registerCreator()method whose removal had been blocked by a similar problem. There are some legacy PlugValueWidget registrations in the IE codebase that will need updating. I can split this PR in two if you'd prefer to deal with those separately, but since this has been deprecated for years I think now might be the time...