Bookmark search #2873
Bookmark search #2873
Conversation
By default, Qt draws an additional focus box that we don't want.
This is customised via the new `nodeSetMenuSignal()`.
This allows custom extensions to add shortcuts for any editor. It also fixes GafferHQ#495.
This allows keyboard shortcuts registered by extensions to work even without a node selected.
This allows keyboard shortcuts to be processed still. Perhaps we should be deferring the enabled status updates to the sections themselves anyway?
I realise this might be a misleading description, given that my screenshot only has nodes with default names. The structure of the menu actually matches the structure (nesting of boxes) of the node graph, and uses the names and not the types of the nodes. What is similar is that the same search code is used, and the same disambiguation mechanism is used when there are multiple matches at different points of the hierarchy. |
There's no point in storing `False`, because that has the same effect as no metadata.
I'm going to say no for now, both because creating the bookmarks is less common, and because in most of the editors we won't be providing any visual feedback as to what has happened. We can revisit based on wider feedback, and/or after Matti's #2729 has added the super-quick bookmarking for super-important nodes. |
This adds the following :
This is based on suggestions made by Murray and Yuta during internal discussion of #2784. It also provides some groundwork for improving the implementation of #2729, particularly replacing the hardcoding and duplication of d97dd8f with a simple bolt-on config for all editors.